Three problems

[PaulCampbell]

Hi,

Thanks for providing this great resource to fans of Fighting Fantasy!

I've been experimenting and I'm afraid I have a couple of problems...


Problem #1

I'm trying to add a function to my character sheet which doesn't seem to work and can't see where the problem lies.

The idea is that if the character has provisions available, you can click on a link to eat them (and restore some Stamina). If they don't have provisions then the option isn't available.

The code I've written is:

<IF condition="$provisions==0" truecolor="hidden"><OPTION option="&gain_stat('stamina',4); $provisions=$provisions-1" count="infinite">Eat provisions</OPTION></IF>

I know that the OPTION part works (since it works on its own outwith the <IF></IF> statement) but putting it between <IF></IF> tags just gives me unclickable text.


Problem #2

There also seems to be a problem with &combat_1on1.
On a certain page, I've added:

<SCRIPT script="&combat_1on1(332,1,0,'Angry Man',6,8,);"></SCRIPT>

... as per instructions elsewhere on the forum and the following confused message is the result:

Combat Round:0
You have taken all the damage you can, and lost this combat.
Combat Status:won

(With the text option I've written for a win appearing after)


Problem 3

&testluck() seems to (i) subtract 2 from current Luck, (ii) fail to provide a warning if Luck drops below 2 (which I had the impression it was supposed to do), and (iii) allow Luck to drop below 0.


I'm sorry to be a nuisance but I thought addressing all of my problems in one post would be better than posting three different problems.

Keep up the good work and thanks again for providing this resource.

P

[Zaphod Beeblbrox]

Hi Paul

It's great to see someone really getting stuck into the gory bits of the system!

ok:

1) your IF tag requires the 'reval' attribute set to true. Without this the condition attribute of that tag will only ever be evaluated once and the result of evaluating it is stored and re-used. Setting it to true means that the condition part will be re-evaluated every time. Believe me forgetting to set that attribute has been a cause of many frustrations for me especially when checking for a combat victory situation.

2) Can't explain that one off the top of my head will get back to you asap

3)
i) can't explain that will get back asap
ii) The warning will only appear if &testluck() is called through the SCRIPT tag (or any tag that renders output from SEL at this moment that is only the SCRIPT tag). If you are using it within a SCRIPT tag and it's not appearing let me know I will investigate further.
iii) I believe I have allowed Luck to drop below 0 deliberately after enquiring for a community view on the Yahoo group forums. I will verify this shortly. However you seem a pretty competent coder I should imagine rewriting that particular routine to not allow dropping below 0 would be pretty trivial for you... ;-)

Please be assured you are far from being a nuisance with your enquiry - I fully expect many problems to arise with using the system as it is far from a finished product (and far from easy to use) and greatly value any and all input I get.

Good luck and I'll get back to you with those 2 unanswered points asap

Jason

[Zaphod Beeblbrox]

Ok to address point 2)

&combat_1on1(332,1,0,'Angry Man',6,8,);

You have a trailing comma after the final parameter to the function (after the '8'). Having tested that line with it in (same result as you) and without (works fine) that seems to be the problem. However it *shouldn't* be a problem and highlights a core problem with the interpreter so many thanks! (Mind you I expect it'll be some time before I fix it).

Will have a look at the &testluck() problem later.

[Zaphod Beeblbrox]

I'm afraid I have been unable to re-create the problems with the &testluck() routine mentioned - more specifically the loss of 2 luck.

The lack of warning may be that you do not actually receive a warning until &testluck() is called when your Luck is actually already below 2, i.e. when you have 1 luck and test your luck thereby reducing you to 0 luck you should also receive the warning at that time (assuming the &testluck() is called within a SCRIPT or OPTION tag - OPTION tags display output in the 'actions' pane).

But I am at a loss for the reduction of 2 points. Maybe you have 2 calls to &testluck(); on that page?

[PaulCampbell]

Thanks for all your help! I haven't got a lot of time at the moment to implement your fixes but I'll feedback once I have.

P